Skip to content

Fix deserialization with missing XML namespace #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2025
Merged

Fix deserialization with missing XML namespace #1327

merged 3 commits into from
Nov 5, 2025

Conversation

@BaerMitUmlaut
Copy link
Contributor

@BaerMitUmlaut BaerMitUmlaut commented Aug 15, 2025

Some S3 implementations do not include the XML namespace in their responses:

<?xml version="1.0" encoding="UTF-8"?>
<CopyObjectResult>
    <LastModified>
        2022-10-29T15:34:41.626Z
    </LastModified>
    <ETag>
        &#34;ead3fcd881dee32547f1b6ca1fc29463&#34;
    </ETag>
</CopyObjectResult>

minio-dotnet fails to deserialize such a response, this PR fixes that.

I encountered this issue in the wild, I'm guessing my provider uses seaweedfs, which has fixed this just hours ago: seaweedfs/seaweedfs#6676
However, they might not be the only ones with that behaviour.

@ebozduman
Copy link
Collaborator

ebozduman commented Oct 31, 2025

@BaerMitUmlaut
I'd like to merge your commit.
I tried to rebase your fix-no-namespace branch so that the format/lint issues hit during the build process in UtilsTest.cs file can be fixed, but it did not work.
Please look into this issue. You may need to rebase your master first, I guess, and then rebase your fix-no-namespace branch, so that I can merge this PR.
Please let me know if you have any questions.

@BaerMitUmlaut
Copy link
Contributor Author

BaerMitUmlaut commented Nov 2, 2025

I think this should fix it, does not complain locally.

ebozduman
ebozduman approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit ac5dc79 into minio:master Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BaerMitUmlaut @ebozduman